Skip to content

fix: adhere to remark's tokenizer rules #7315#7444

Merged
martinjagodic merged 5 commits intodecaporg:mainfrom
fgnass:fix/7315-shortcode-tokenizer
Apr 20, 2026
Merged

fix: adhere to remark's tokenizer rules #7315#7444
martinjagodic merged 5 commits intodecaporg:mainfrom
fgnass:fix/7315-shortcode-tokenizer

Conversation

@fgnass
Copy link
Copy Markdown
Contributor

@fgnass fgnass commented Mar 28, 2025

This PR fixes #7315 by implementing @manulari's suggested approach.

  • The processing time is now linear again
  • A warning is logged when a pattern uses the multiline flag
  • A warning is logged when the match does not start at the beginning of the block

@fgnass fgnass requested a review from a team as a code owner March 28, 2025 21:33
Copy link
Copy Markdown
Contributor

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @fgnass, I've made a few changes to merge correctly, I believe it should be in good shape now.

@martinjagodic martinjagodic enabled auto-merge (squash) April 20, 2026 07:15
@martinjagodic martinjagodic merged commit 50986a0 into decaporg:main Apr 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current code in remarkShortcodes.js misunderstands how remark's block tokenizers are supposed to work

3 participants