Skip to content

Conversation

@dduan
Copy link
Owner

@dduan dduan commented Jan 8, 2026

Make Parser ~Copyable; move storage into TOMLDocument.

Make Parser ~Copyable; move storage into TOMLDocument.
@dduan dduan enabled auto-merge (squash) January 8, 2026 09:53
@dduan dduan changed the title parser: consume finish handoff Consume finish handoff Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Comparing results between 'main' and 'pull_request'

Host 'runnervmi13qx' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

TOMLDecoderBenchmarks

Decode toml.io example metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 68 69 69 70 76 93 154 7168
pull_request 69 70 70 71 76 88 137 7089
Δ 1 1 1 1 0 -5 -17 -79
Improvement % -1 -1 -1 -1 0 5 11 -79

Retains: results within specified thresholds, fold down for details.

Retains * p0 p25 p50 p75 p90 p99 p100 Samples
main 626 626 626 626 626 626 626 7168
pull_request 621 621 621 621 621 621 621 7089
Δ -5 -5 -5 -5 -5 -5 -5 -79
Improvement % 1 1 1 1 1 1 1 -79

Parse toml.io example metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) * p0 p25 p50 p75 p90 p99 p100 Samples
main 5971 6083 6115 6163 6243 10295 30557 10000
pull_request 6052 6175 6211 6255 6335 10063 26951 10000
Δ 81 92 96 92 92 -232 -3606 0
Improvement % -1 -2 -2 -1 -1 2 12 0

Retains: results within specified thresholds, fold down for details.

Retains * p0 p25 p50 p75 p90 p99 p100 Samples
main 9 10 10 10 10 10 10 10000
pull_request 5 6 6 6 6 6 6 10000
Δ -4 -4 -4 -4 -4 -4 -4 0
Improvement % 44 40 40 40 40 40 40 0

decode canada.toml metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ms) * p0 p25 p50 p75 p90 p99 p100 Samples
main 272 273 273 273 274 274 274 4
pull_request 274 274 274 274 275 275 275 4
Δ 2 1 1 1 1 1 1 0
Improvement % -1 0 0 0 0 0 0 0

Retains: results within specified thresholds, fold down for details.

Retains (K) * p0 p25 p50 p75 p90 p99 p100 Samples
main 1674 1674 1674 1674 1674 1674 1674 4
pull_request 1674 1674 1674 1674 1674 1674 1674 4
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

decode twitter.toml metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 9161 9208 9232 9265 9290 9552 9707 108
pull_request 9041 9085 9101 9126 9175 9413 9714 109
Δ -120 -123 -131 -139 -115 -139 7 1
Improvement % 1 1 1 2 1 1 0 1

Retains: results within specified thresholds, fold down for details.

Retains (K) * p0 p25 p50 p75 p90 p99 p100 Samples
main 66 66 66 66 66 66 66 108
pull_request 66 66 66 66 66 66 66 109
Δ 0 0 0 0 0 0 0 1
Improvement % 0 0 0 0 0 0 0 1

parse GitHub events archive metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ms) * p0 p25 p50 p75 p90 p99 p100 Samples
main 164 164 164 174 175 175 175 7
pull_request 163 163 164 165 169 169 169 7
Δ -1 -1 0 -9 -6 -6 -6 0
Improvement % 1 1 0 5 3 3 3 0

Retains: results within specified thresholds, fold down for details.

Retains (K) * p0 p25 p50 p75 p90 p99 p100 Samples
main 77 77 77 77 77 77 77 7
pull_request 77 77 77 77 77 77 77 7
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

parse canada.toml metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ms) * p0 p25 p50 p75 p90 p99 p100 Samples
main 16 17 17 18 18 19 19 59
pull_request 16 17 17 18 18 19 19 58
Δ 0 0 0 0 0 0 0 -1
Improvement % 0 0 0 0 0 0 0 -1

Retains: results within specified thresholds, fold down for details.

Retains * p0 p25 p50 p75 p90 p99 p100 Samples
main 133 134 134 134 134 134 134 59
pull_request 129 130 130 130 130 130 130 58
Δ -4 -4 -4 -4 -4 -4 -4 -1
Improvement % 3 3 3 3 3 3 3 -1

parse twitter.toml metrics

Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) * p0 p25 p50 p75 p90 p99 p100 Samples
main 2705 2753 2767 2781 2800 2945 3291 354
pull_request 2714 2763 2773 2785 2796 2896 3274 354
Δ 9 10 6 4 -4 -49 -17 0
Improvement % 0 0 0 0 0 2 1 0

Retains: results within specified thresholds, fold down for details.

Retains * p0 p25 p50 p75 p90 p99 p100 Samples
main 1293 1294 1294 1294 1294 1294 1294 354
pull_request 1289 1290 1290 1290 1290 1290 1290 354
Δ -4 -4 -4 -4 -4 -4 -4 0
Improvement % 0 0 0 0 0 0 0 0

@dduan dduan merged commit 1f57f34 into main Jan 8, 2026
16 checks passed
@dduan dduan deleted the dd/parser-consume-finish-handoff branch January 8, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants