Skip to content

Report string errors properly #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dduan merged 2 commits into from
Dec 31, 2025
Merged

Report string errors properly #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69ec676
Report string errors properly
dduan Dec 30, 2025
e6041b3
Fix format
dduan Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Sources/TOMLDecoder/Parsing/Parser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,8 +1100,6 @@ extension Token {
var index = text.lowerBound
var endIndex = text.upperBound

assert(quoteChar == CodeUnits.doubleQuote || quoteChar == CodeUnits.singleQuote)

if endIndex - index >= 3 && bytes[index] == CodeUnits.doubleQuote && bytes[index + 1] == CodeUnits.doubleQuote && bytes[index + 2] == CodeUnits.doubleQuote ||
endIndex - index >= 3 && bytes[index] == CodeUnits.singleQuote && bytes[index + 1] == CodeUnits.singleQuote && bytes[index + 2] == CodeUnits.singleQuote
{
Expand All @@ -1117,7 +1115,7 @@ extension Token {
} else {
index = index + 1
endIndex = endIndex - 1
guard bytes[endIndex] == quoteChar else {
guard endIndex >= 0, bytes[endIndex] == quoteChar else {
throw TOMLError(.invalidString(context: context, lineNumber: lineNumber, reason: "missing closing quote"))
}
}
Expand Down
Loading