Skip to content

Conversation

@deronnax
Copy link
Contributor

@deronnax deronnax commented May 22, 2024

Description

Following PEP 621, setup.py is soft-deprecated (not truly deprecated but not the way to go anymore) and metadata in pyproject.toml is the new norm. This change should be functionally strictly equivalent.

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@j-bennet
Copy link
Contributor

j-bennet commented May 22, 2024

Thanks for the PR @deronnax , this has been overdue for some time. CI is not happy with the change though, do you think you could figure this out, or need help? Our CI workflow is pretty simple, so I'm surprised there's been a hiccup:

https://github.com/dbcli/pgcli/blob/main/.github/workflows/ci.yml

but perhaps we're missing something there.

Copy link
Member

@dbaty dbaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments from a (very) cursory review. I'll make a second pass in the coming days to make sure that the new pyproject-based version is equivalent to what was set in setup.py.

@deronnax deronnax force-pushed the mdupuy/-/migrate-to-pyproject-toml branch from 41c8be9 to e647319 Compare May 27, 2024 15:07
@j-bennet j-bennet requested a review from dbaty May 29, 2024 05:48
@deronnax deronnax force-pushed the mdupuy/-/migrate-to-pyproject-toml branch from a0d71f3 to 9284371 Compare July 11, 2024 11:41
@deronnax deronnax force-pushed the mdupuy/-/migrate-to-pyproject-toml branch from 9284371 to 94c0911 Compare July 11, 2024 11:43
@deronnax
Copy link
Contributor Author

All concerns addressed. Sorry for the oversights.

@deronnax deronnax requested a review from dbaty July 11, 2024 11:43
@deronnax
Copy link
Contributor Author

deronnax commented Dec 3, 2024

@j-bennet let's merge ?

@j-bennet
Copy link
Contributor

j-bennet commented Dec 4, 2024

@deronnax Yes! thanks for the ping.

@j-bennet j-bennet merged commit 5001f94 into dbcli:main Dec 4, 2024
7 checks passed
@j-bennet
Copy link
Contributor

j-bennet commented Dec 4, 2024

Merged! Well done @deronnax and @dbaty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants