Create key_binding_utils.py and migrate functions to it#1814
Merged
rolandwalker merged 1 commit intomainfrom Apr 4, 2026
Merged
Create key_binding_utils.py and migrate functions to it#1814rolandwalker merged 1 commit intomainfrom
key_binding_utils.py and migrate functions to it#1814rolandwalker merged 1 commit intomainfrom
Conversation
and migrate functions to it. Motivation: move code out of main.py. This may be a bit overenthusiastic, as all command handlers are moved there, even the \clip handler, which does not have a keybinding. And maybe "handlers" are not a fit with "utils". As a comment notes, the handlers might be better moved later to a repl_handlers.py. But that move would be premature before we have a repl.py.
rolandwalker
force-pushed
the
RW/create-key-binding-utils
branch
from
d668bd2 to
2b6d06c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create
key_binding_utils.pyand migrate functions to it.Motivation: move code out of
main.py.This may be a bit overenthusiastic, as all command handlers are moved there, even the
\cliphandler, which does not have a keybinding. And maybe "handlers" are not a fit with "utils".As a comment notes, the handlers might be better moved later to a
repl_handlers.py. But that move would be premature before we have arepl.py.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).