Skip to content

Reduce duplicate --checkup outputs #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolandwalker merged 1 commit into from
Feb 9, 2026
Merged

Reduce duplicate --checkup outputs #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ Features
* Suggest tables/views that contain the given columns first when provided in a SELECT query.


Bug Fixes
--------
* Reduce duplicated `--checkup` output.


Internal
--------
* Let CI ignore additional documentation files.
Expand Down
4 changes: 4 additions & 0 deletions mycli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2284,6 +2284,7 @@ def do_config_checkup(mycli: MyCli) -> None:
f'{indent}[main]\n{indent}default_character_set': f'{indent}[connection]\n{indent}default_character_set',
f'{indent}[main]\n{indent}ssl_mode': f'{indent}[connection]\n{indent}default_ssl_mode',
}
reverse_transitions = {v: k for k, v in transitions.items()}

if not list(mycli.config.keys()):
print('\nThe local ~/,myclirc is missing or empty.\n')
Expand All @@ -2297,6 +2298,9 @@ def do_config_checkup(mycli: MyCli) -> None:
did_output_missing = True
continue
for item_name in mycli.config[section_name]:
transition_key = f'{indent}[{section_name}]\n{indent}{item_name}'
if transition_key in reverse_transitions:
continue
if item_name not in mycli.config_without_package_defaults[section_name]:
if not did_output_missing:
print('\n### Missing in user ~/.myclirc:\n')
Expand Down