[feat] Suggest tables that include the given column(s) in a SELECT statement first before other tables #1522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the suggestion logic for SELECT queries by suggesting tables that contain the given columns first before other tables that do not contain the given columns. For example:
Given the below tables:
TableA = ID, Name
TableB = ID, City
TableC = ID, School
SELECT ID FROMwould suggest all three tablesSELECT School FROMwould suggest TableC first (match), then TableA and TableB (no match)SELECT City, School FROMwould suggest TableB and TableC (match), then TableA (no match)This also works for sub selects, and is based on the closest select. I.e. (using the same above tables):
SELECT * FROM (SELECT City FROMwould suggest TableB first (match) since the closest select is forCityand not*, followed by TableA and TableC (no match).Checklist
changelog.mdfile.AUTHORSfile (or it's already there).