Let reconnect preserve session state #1420
Open
+122
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followups to
reconnect()refactor:sqlexecute.connect(), tryping(reconnect=True)to do a true reconnect, preserving theconnection_id()and other state such as session variables. This is the important part, which the commentary calls the "second pass".ping(reconnect=True), tryping(reconnect=False)with fewer feedback messages, which the commentary calls the "first pass". This pass is helpful to keep chatter down when the user habitually chooses the "connect" verb over "use".manual_reconnect()eg: "real function" -> "utility method"manual_reconnect()andchange_db(), keeping thedatabaseoptional argument, as it is still useful for finessing feedback messages.manual_reconnect()yield the result ofchange_db(), leaving us directly hooked in to the 4-tuple return-value system (instead of iterating onchange_db()internally and manually handling theecho()).self.sqlexecute.connbefore pinging it.reconnect()docstring. (Pedantically it could be "cluster" or "endpoint").mycli.packages.special.execute()rather thanCliRunner().CliRunner()is only capable of testing the first line of output, which is taken up by an initialization statement.xref #1416
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.