Miscellaneous typing updates to fix CI #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
force-pushed
the
RW/typing-updates-20251215
branch
from
c31e84a to
ec82df7
Compare
* don't reuse a variable name with different types * the last argument to suggest_based_on_last_token() must be an Identifier * extract_from_part() is a Generator of Any, which extract_table_identifiers() must accept * check the first half of the result of subst_favorite_query_args(), so that mypy can deduce that "query" does not hold a None
rolandwalker
force-pushed
the
RW/typing-updates-20251215
branch
from
ec82df7 to
88b35e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
suggest_based_on_last_token()must be anIdentifierextract_from_part()is aGeneratorofAny, whichextract_table_identifiers()must acceptsubst_favorite_query_args(), so that mypy can deduce thatquerydoes not hold aNoneChecklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.