fix: guard self.unit against None in __repr__#652
Open
thakoreh wants to merge 1 commit intodbader:masterfrom
Open
fix: guard self.unit against None in __repr__#652thakoreh wants to merge 1 commit intodbader:masterfrom
thakoreh wants to merge 1 commit intodbader:masterfrom
Conversation
Added None check before slicing self.unit to prevent crash when self.unit is None and self.interval == 1. Fixes dbader#646
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #646
Problem
When
self.interval == 1andself.unitisNone, the code attempts to sliceself.unit[:-1], which causes a crash.Solution
Added a guard to check that
self.unitis notNonebefore attempting to slice it:This change is applied to both occurrences in the
__repr__method (lines 305 and 320).