Split out the container, display, positioning and spacing helpers.#6
Open
animald wants to merge 6 commits intodaveberning:developfrom
Open
Split out the container, display, positioning and spacing helpers.#6animald wants to merge 6 commits intodaveberning:developfrom
animald wants to merge 6 commits intodaveberning:developfrom
Conversation
Output them to their own dist folder.
Author
|
@daveberning Hi, have you had a chance to review this? I'd really like to use your grid and spacing/display/flex helpers on a project I'm working on. Thanks in advance! |
Author
|
@daveberning Apologies for spamming you, but I've given this some more thought and I guess in essence what I'm after is griddle without any theme elements such as colours and component/element styles. Perhaps it would be better to output a theme-less version that contains all the other useful stuff? Ultimately you might want to offer a bit more control to users, let them pull in exactly what they need by importing the necessary files as scss. Happy to contribute to that end should you decide it's a route you want to go down! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output them to their own dist folder.