refactor: remove n0des tickets, no longer used #62
+60
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
refactor/remove-n0des-tickets
branch
2 times, most recently
from
0b94bbe to
63dc6e0
Compare
mattdjenkinson
approved these changes
Feb 6, 2026
Frando
force-pushed
the
refactor/remove-n0des-tickets
branch
from
63dc6e0 to
f3f57ff
Compare
zachsmith1
approved these changes
Feb 6, 2026
Contributor
|
100% agree on local state vs datum control plane. haven't gotten around to that clean up yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app is no longer using the n0des tickets feature. Proxies are now stored in the Datum Cloud APIs instead.
This removes the functionality to publish and resolve tickets via n0des.
It does keep the n0des endpoint, for metrics collection. However this is now optional, so the app will work without a N0DES_API_SECRET without any issues, only metrics collection onto n0des will be disabled.
Writing this PR shows that, in my opinion, another refactor is due: The logic to update proxies both in the local state (actually accept requests on a new tunnel) and on datum (store the connector and advertisment in the Datum API) currently lives in the ui crate only. See the various
save_create_tunnel/save_proxysignals. This is not very clean IMO and quite error-prone. This should all be handled by the TunnelService, which already contains a ListenNode and a DatumCloudClient. I'll create an issue for this.