Refine the vectorize annotations to cover all cases (+ extensive tests/examples)#136
Open
Refine the vectorize annotations to cover all cases (+ extensive tests/examples)#136
Conversation
52abad6 to
b866c02
Compare
Collaborator
Author
|
@stephenatsembit This is a little bit I think we missed in making 125 final (the coexistence of the ColumnVector and ColumnVectorize on a collection document class, I mean). See PR message. |
…t of my eyes all the time
…ed constructors to CollectionVector attribute
…alue is actually set
8527707 to
fd9ce57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps track of the coverage for all vectorize-related situations. To do so it adds a bunch of create-X tests. Along the way, a change in the code (besides tests) is done.
The matrix is now complete and runs on the post-125-merged codebase... except one case (double attribute, typed collection, test
CreateCollection_WithVectorizeSharedSecretDoubleAttribute_Typed) which:ColumnVectorAttribute(part of this PR)Note that most of the 15 added tests require some DB/ops setup (API keys and such). These new tests are all disabled by default anyway.
Examples are tested on Astra/HCD, anything that applies.
Vectorize status:
Note on header-based auth
The header is passed as a certain field within certain
*CommandOptionclasses. There is an asymmetry here between tables and collections:All three "bottom" classes support the
new <className>() { EmbeddingApiKey = embeddingAPIKey }pattern to be passed to the appropriateGet/Create x Table/Collectionmethod: however there are two different ones for tables ... because of "ifNotExists" (which does not make sense whenGetting a table, nor does it for a collection).