Set-DbaNetworkCertificate: Refactor with best practices and Test-DbaNetworkCertificate validation#10227
Closed
andreasjordan wants to merge 1 commit intodevelopmentfrom
Closed
Set-DbaNetworkCertificate: Refactor with best practices and Test-DbaNetworkCertificate validation#10227andreasjordan wants to merge 1 commit intodevelopmentfrom
andreasjordan wants to merge 1 commit intodevelopmentfrom
Conversation
…etworkCertificate validation - Use Test-DbaNetworkCertificate to validate certificate suitability before setting - Add -SkipCertificateValidation switch to bypass validation when needed - Add [ValidatePattern] to enforce 40-char hex thumbprint format - Fix PSEdition check: use PSVersionTable.PSVersion.Major for PS v3 compatibility - Remove redundant ParameterSets; use Test-Bound pattern instead - Fix variable casing: KeyFullPath consistency in else branch - Wrap ACL operations in try/catch with proper error handling - Fix registry read: add -ErrorAction SilentlyContinue for first-time setup - Search only in LocalMachine\My (not all cert stores) - Add HasPrivateKey check in script block - Add explicit continue after Stop-Function -Continue in foreach loop - Update test file with SkipCertificateValidation parameter (do Set-DbaNetworkCertificate) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
Collaborator
Author
|
I'm not happy with major parts of this pr, so I will close and work on a new pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors Set-DbaNetworkCertificate to use Test-DbaNetworkCertificate for certificate validation and applies all best practices identified in the code review.
Changes:
Closes #10125
Generated with Claude Code