This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Change comparison operator based on inclusive vs exclusive ranges#16
Open
jwkoelewijn wants to merge 1 commit intodatamapper:masterfrom
Open
Change comparison operator based on inclusive vs exclusive ranges#16jwkoelewijn wants to merge 1 commit intodatamapper:masterfrom
jwkoelewijn wants to merge 1 commit intodatamapper:masterfrom
Conversation
Conflicts: lib/dm-do-adapter/spec/shared_spec.rb
tpitale
changed the title
Member
|
It seems like prior to this inclusive ranges were not handled in any way. So … this adds support for inclusive ranges? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Range with in inclusive end was used, the entire Range would be partitioned. This is not necessary, because only the first and the last item of the Range are important.
This could result in poor performance when using big ranges.
The fix just changes the comparison operator based on whether the range is inclusive or exclusive.