Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This repository contains my submission for the DataMade Junior Developer position.
Demo
Screen.Recording.2026-03-13.at.8.11.07.PM.mov
Notes
Frontend Data Fetching
If this application were expanded further, I would likely introduce something like TanStack Query for data fetching instead of using useEffect.
TanStack Query provides:
Loading States
In this implementation, the data is fetched from a local file, so latency is negligible.
If the data were retrieved from a database or external API, I would add:
Error Handling
In a production application, I would add an Error Boundary to catch unexpected rendering errors and prevent the entire React application from crashing.
Map Visualization
Some of the map colors were difficult to distinguish. Increasing the contrast between color ranges would improve readability and accessibility of the map.
Data Validation
I would add validation for the GeoJSON data to ensure it matches the expected schema before rendering.
In TypeScript projects I typically use Zod for schema validation to catch malformed data before it reaches the UI.
URL State / Shareability
Another improvement would be storing filter state (for example the selected year) in URL search parameters.