Ensure file handles are correctly disposed#451
Open
KodrAus wants to merge 4 commits intodatalust:devfrom
Open
Conversation
Member
Author
|
I’ve updated our test infrastructure here to run against both the real and in-memory filesystems and refactored the chunk reading logic so it’s clearer, fixing a few issues along the way. I think this should be good for a review now, but would like to kick the tyres a bit more to be sure there aren’t any other degenerate cases lurking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #448
This PR aims to track down potential file handle leakage in the forwarder's storage engine due to missing
Disposecalls, of which there are a few inBufferReader. The test filesystem now tracks active handles and throws when attempting to delete a file with any active. I'll also update it to run a real tmp directory side-by-side and compare the results.