refactor: remove text from core types, keep as native passthrough#1318
Merged
dimitri-yatsenko merged 1 commit intopre/v2.0from Jan 9, 2026
Merged
refactor: remove text from core types, keep as native passthrough#1318dimitri-yatsenko merged 1 commit intopre/v2.0from
dimitri-yatsenko merged 1 commit intopre/v2.0from
Conversation
`text` is no longer a core DataJoint type. It remains available as a native SQL passthrough type (with portability warning). Rationale: - Core types should encourage structured, bounded data - varchar(n) covers most legitimate text needs with explicit bounds - json handles structured text better - <object> is better for large/unbounded text (files, sequences, docs) - text behavior varies across databases, hurting portability Changes: - Remove `text` from CORE_TYPES in declare.py - Update NATIVE_TEXT pattern to match plain `text` (in addition to tinytext, mediumtext, longtext) - Update archive docs to note text is native-only Users who need unlimited text can: - Use varchar(n) with generous limit - Use json for structured content - Use <object> for large text files - Use native text types with portability warning Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
textfrom core DataJoint types. It remains available as a native SQL passthrough type (with portability warning).Rationale
Core types should encourage structured, bounded data:
varchar(n)with explicit limitjson<object>varchar(4000)typically sufficientProblems with
textas a core type:Changes
declare.py:
textfromCORE_TYPESNATIVE_TEXTpattern:r"(tiny|small|medium|long)?text$"(now includes plaintext)Documentation:
Migration
Users who need text can:
Related
🤖 Generated with Claude Code