fix: return 0 from delete() when user cancels operation#1316
Merged
dimitri-yatsenko merged 1 commit intopre/v2.0from Jan 9, 2026
Merged
fix: return 0 from delete() when user cancels operation#1316dimitri-yatsenko merged 1 commit intopre/v2.0from
dimitri-yatsenko merged 1 commit intopre/v2.0from
Conversation
When a user answers "no" to "Commit deletes?", the transaction is rolled back but delete() still returned the count of rows that would have been deleted. This was unintuitive - if nothing was deleted, the return value should be 0. Now delete() returns 0 when: - User cancels at the prompt - Nothing to delete (already worked correctly) Fixes #1155 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
delete()to return 0 when the user cancels the operation at the prompt.Problem
When a user answered "no" to "Commit deletes?", the transaction was correctly rolled back, but
delete()still returned the count of rows that would have been deleted.Fix
Reset
delete_countto 0 when the delete is cancelled:Behavior
Closes
🤖 Generated with Claude Code