refactor(llm): converge service-level LLM calls to unified client#61
Open
Congregalis wants to merge 1 commit intodataelement:mainfrom
Open
refactor(llm): converge service-level LLM calls to unified client#61Congregalis wants to merge 1 commit intodataelement:mainfrom
Congregalis wants to merge 1 commit intodataelement:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR converges remaining service-level direct LLM HTTP calls into the unified LLM client abstraction.
It is a preparatory refactor to reduce protocol drift and make future provider expansion (e.g., OpenAI Responses API, Gemini) safer and more localized.
Closes #60
What Changed
/chat/completionsHTTP call path in agent-to-agent messaging withcreate_llm_client()+ unifiedLLMMessage/LLMResponseflow./chat/completionsHTTP call path in supervision reminder reply generation withcreate_llm_client()+ unified flow.Why
Previously, these service paths bypassed the unified client and hardcoded request/response assumptions. That made future provider support harder and increased inconsistency risk across runtime flows.
After this change, protocol-specific handling is more centralized in the LLM client layer, which lowers the cost of adding provider types like OpenAI Responses and Gemini.
Scope Notes
provider + protocol).Impact
Validation
/chat/completionsusage was removed from the affected paths.