build(deps): bump pyasn1 from 0.6.1 to 0.6.2 #362
Conversation
Bumps [pyasn1](https://github.com/pyasn1/pyasn1) from 0.6.1 to 0.6.2. - [Release notes](https://github.com/pyasn1/pyasn1/releases) - [Changelog](https://github.com/pyasn1/pyasn1/blob/main/CHANGES.rst) - [Commits](pyasn1/pyasn1@v0.6.1...v0.6.2) --- updated-dependencies: - dependency-name: pyasn1 dependency-version: 0.6.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
|
||
| [[package]] | ||
| name = "pyasn1" | ||
| version = "0.6.1" | ||
| version = "0.6.2" | ||
| description = "Pure-Python implementation of ASN.1 types and DER/BER/CER codecs (X.208)" | ||
| optional = true | ||
| optional = false | ||
| python-versions = ">=3.8" |
There was a problem hiding this comment.
Bug: The pyasn1 dependency was incorrectly changed from an optional to a required dependency, causing dependency bloat for minimal installations.
Severity: HIGH
Suggested Fix
Regenerate the poetry.lock file to respect the optional nature of pyasn1. Ensure it is only included when extras that transitively depend on it (e.g., bigquery, mysql) are specified. This may require restoring the optional = true flag and the markers field for the pyasn1 package.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: poetry.lock#L3258-L3264
Potential issue: The update to `poetry.lock` incorrectly promotes the `pyasn1` package
from an optional to a required dependency. Previously, `pyasn1` was only installed when
specific extras like `bigquery` or `mysql` were requested, as it is a transitive
dependency of drivers like `sqlalchemy-bigquery` and `pymysql[rsa]`. Now, `pyasn1` will
be installed for all users, even those performing a minimal installation without any
database connectors. This introduces unnecessary dependency bloat and breaks the
expectation of a minimal installation.
Did we get this right? 👍 / 👎 to inform future reviews.
Bumps pyasn1 from 0.6.1 to 0.6.2.
Release notes
Sourced from pyasn1's releases.
Changelog
Sourced from pyasn1's changelog.
Commits
e7356f8Prepare release 0.6.23908f14Merge commit from fork0a7e067Add support for Python 3.14 (#97)33656e9Create Security Policyfa62307fix for issue #91: unit tests failing due to missing code (#92)f1ed02ePackage pyasn1 with pyproject.toml (#90)93c4d4fSwitch documentation user to pyasn1 (#89)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.