[do not merge] Test GCP header in workspace#1328
Open
hectorcast-db wants to merge 1 commit intomainfrom
Open
Conversation
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
## Summary - Removes the `ClientType.ACCOUNT` guard on GCP SA access token refresh in both `google_credentials` and `google_id` credential providers - Always attempts to refresh the GCP SA access token, but catches failures with a warning log instead of blocking authentication - Users who lack permissions to mint the GCP SA access token will no longer fail auth entirely ## Test plan - [x] Added `test_google_credentials_includes_sa_token_on_success` — verifies SA token header is included when refresh succeeds - [x] Added `test_google_credentials_warns_on_sa_token_failure` — verifies warning is logged and SA token header is omitted on failure - [x] Added `test_google_id_includes_sa_token_on_success` — verifies SA token header is included when refresh succeeds - [x] Added `test_google_id_warns_on_sa_token_failure` — verifies warning is logged and SA token header is omitted on failure - [x] Run all our tests passing always a (potentially dummy) SA header: #1328 This pull request was AI-assisted by Isaac. NO_CHANGELOG=true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR
This PR injects always a dummy ["X-Databricks-GCP-SA-Access-Token"] header. This header is replaced by the real one if the auth type uses it.
This is done to validate that this header is safe to be added to workspace operations (usually it is only added to account ones)