Add support for direct dataplane access #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…vant to direct dataplane access
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
databricks-sdk-java/src/main/java/com/databricks/sdk/core/http/RequestOptions.java
Show resolved
Hide resolved
...ks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/OAuthHeaderFactoryFromSuppliers.java
Outdated
Show resolved
Hide resolved
…/RequestOptions.java Update class description of RequestOptions Co-authored-by: Renaud Hartert <renaud.hartert@databricks.com>
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksConfig.java
Outdated
Show resolved
Hide resolved
Comment on lines
+21
to
+23
| public ServingEndpointsDataPlaneAPI( | ||
| ApiClient apiClient, DatabricksConfig config, ServingEndpointsAPI servingEndpointsAPI) { | ||
| impl = new ServingEndpointsDataPlaneImpl(apiClient, config, servingEndpointsAPI); |
Contributor
There was a problem hiding this comment.
This code should be generated, is this PR meant to be merged after the code generation PR?
Contributor
Author
There was a problem hiding this comment.
I am not sure how the procedure for syncing the generated code and hand-written code works, but I have made a PR on universe for the updated templates. Perhaps you can take a look at it to make sure everything is fine and then I will remove it from the PR here along with WorkspaceClient and the implementation :)
Contributor
There was a problem hiding this comment.
SG, let's merge the codegen first 👍
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
approved these changes
May 27, 2025
Contributor
renaudhartert-db
left a comment
renaudhartert-db
left a comment
There was a problem hiding this comment.
LGTM, to be merged once we have merged the code generation PR first.
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksConfig.java
Show resolved
Hide resolved
parthban-db
approved these changes
May 27, 2025
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This reverts commit ec211f3.
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
deco-sdk-tagging bot
added a commit
that referenced
this pull request
May 27, 2025
## Release v0.52.0 ### New Features and Improvements * Added Direct-to-Dataplane API support, allowing users to query route optimized model serving endpoints ([#453](#453)). ### API Changes * Added `workspaceClient.dashboardEmailSubscriptions()` service and `workspaceClient.sqlResultsDownload()` service. * Added `remoteShuffleDiskIops`, `remoteShuffleDiskThroughput` and `totalInitialRemoteShuffleDiskSize` fields for `com.databricks.sdk.service.compute.ClusterAttributes`. * Added `remoteShuffleDiskIops`, `remoteShuffleDiskThroughput` and `totalInitialRemoteShuffleDiskSize` fields for `com.databricks.sdk.service.compute.ClusterDetails`. * Added `remoteShuffleDiskIops`, `remoteShuffleDiskThroughput` and `totalInitialRemoteShuffleDiskSize` fields for `com.databricks.sdk.service.compute.ClusterSpec`. * Added `remoteShuffleDiskIops`, `remoteShuffleDiskThroughput` and `totalInitialRemoteShuffleDiskSize` fields for `com.databricks.sdk.service.compute.CreateCluster`. * Added `remoteShuffleDiskIops`, `remoteShuffleDiskThroughput` and `totalInitialRemoteShuffleDiskSize` fields for `com.databricks.sdk.service.compute.EditCluster`. * Added `remoteShuffleDiskIops`, `remoteShuffleDiskThroughput` and `totalInitialRemoteShuffleDiskSize` fields for `com.databricks.sdk.service.compute.UpdateClusterResource`. * Added `tags` field for `com.databricks.sdk.service.pipelines.CreatePipeline`. * Added `tags` field for `com.databricks.sdk.service.pipelines.EditPipeline`. * Added `tags` field for `com.databricks.sdk.service.pipelines.PipelineSpec`. * Added `maxProvisionedConcurrency` and `minProvisionedConcurrency` fields for `com.databricks.sdk.service.serving.ServedEntityInput`. * Added `maxProvisionedConcurrency` and `minProvisionedConcurrency` fields for `com.databricks.sdk.service.serving.ServedEntityOutput`. * Added `maxProvisionedConcurrency` and `minProvisionedConcurrency` fields for `com.databricks.sdk.service.serving.ServedModelInput`. * Added `maxProvisionedConcurrency` and `minProvisionedConcurrency` fields for `com.databricks.sdk.service.serving.ServedModelOutput`. * Added `DELTASHARING_CATALOG`, `FOREIGN_CATALOG`, `INTERNAL_CATALOG`, `MANAGED_CATALOG`, `MANAGED_ONLINE_CATALOG`, `SYSTEM_CATALOG` and `UNKNOWN_CATALOG_TYPE` enum values for `com.databricks.sdk.service.catalog.CatalogType`. * Added `GA4_RAW_DATA`, `POWER_BI`, `SALESFORCE`, `SALESFORCE_DATA_CLOUD`, `SERVICENOW`, `UNKNOWN_CONNECTION_TYPE` and `WORKDAY_RAAS` enum values for `com.databricks.sdk.service.catalog.ConnectionType`. * Added `OAUTH_ACCESS_TOKEN`, `OAUTH_M2M`, `OAUTH_REFRESH_TOKEN`, `OAUTH_RESOURCE_OWNER_PASSWORD`, `OAUTH_U2M`, `OAUTH_U2M_MAPPING`, `OIDC_TOKEN`, `PEM_PRIVATE_KEY`, `SERVICE_CREDENTIAL` and `UNKNOWN_CREDENTIAL_TYPE` enum values for `com.databricks.sdk.service.catalog.CredentialType`. * Added `CATALOG`, `CLEAN_ROOM`, `CONNECTION`, `CREDENTIAL`, `EXTERNAL_LOCATION`, `EXTERNAL_METADATA`, `FUNCTION`, `METASTORE`, `PIPELINE`, `PROVIDER`, `RECIPIENT`, `SCHEMA`, `SHARE`, `STAGING_TABLE`, `STORAGE_CREDENTIAL`, `TABLE`, `UNKNOWN_SECURABLE_TYPE` and `VOLUME` enum values for `com.databricks.sdk.service.catalog.SecurableType`. * Added `TERADATA` enum value for `com.databricks.sdk.service.pipelines.IngestionSourceType`. * Added `OIDC_FEDERATION` enum value for `com.databricks.sdk.service.sharing.AuthenticationType`. * [Breaking] Changed `securableType` field for `com.databricks.sdk.service.catalog.ConnectionInfo` to type `com.databricks.sdk.service.catalog.SecurableType` class. * [Breaking] Changed `catalogType` field for `com.databricks.sdk.service.catalog.SchemaInfo` to type `com.databricks.sdk.service.catalog.CatalogType` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR introduces direct dataplane access to the Java SDK.
Key Changes
1. OAuth Header Factory Implementation
OAuthHeaderFactoryinterface that combinesHeaderFactoryandTokenSourcefunctionality2. Error Token Source
ErrorTokenSourceimplementation that provides clear error messages when OAuth tokens are not supported3. OAuth Authentication Flow Changes
OAuthHeaderFactoryinstead of basicHeaderFactoryHow is this tested?
Added unit tests for all new classes including
OAuthHeaderFactory,ErrorTokenSource, along with tests forconfig.getTokenSource(). The feature has been manually validated end-to-end by creating a model serving endpoint with route optimization enabled and successfully sending queries through the dataplane access path.