[HOLD][Internal] Remove account_id fallback for TokenAudience resolution#1623
Draft
[HOLD][Internal] Remove account_id fallback for TokenAudience resolution#1623
Conversation
TokenAudience is now only set from `token_federation_default_oidc_audiences` in the host metadata discovery response. The previous fallback to AccountID for account hosts is removed, to be merged after the API with the audience field is deployed. Co-authored-by: Isaac Signed-off-by: Tanmay Rustagi <tanmay.rustagi@databricks.com>
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
changed the title
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
tanmay-db
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
AccountIDfallback forTokenAudienceduring host metadataresolution.
TokenAudienceis now only set fromtoken_federation_default_oidc_audiencesin the discovery endpoint response.Why
The
/.well-known/databricks-configendpoint is being updated to alwaysreturn
token_federation_default_oidc_audiences. Once deployed, the SDKno longer needs to guess the audience from
AccountIDfor account hosts.The fallback was a temporary workaround for hosts that didn't yet serve
the audience field. This PR should be merged after the API change is
deployed.
What changed
Interface changes
None.
Behavioral changes
When
token_federation_default_oidc_audiencesis absent from the hostmetadata response,
TokenAudienceis no longer set toAccountIDas afallback. It remains empty, and the OIDC token source's own
determineAudiencelogic handles the default.Internal changes
AccountIDfallback block fromConfig.resolveHostMetadata.TestApplyHostMetadata_TokenFederationDefaultOIDCAudiencesTakesPriorityOverAccountIDFallback(no longer meaningful without the fallback).
TestApplyHostMetadata_FallsBackToAccountIDWhenNoTokenFederationDefaultOIDCAudienceswith
TestApplyHostMetadata_DoesNotFallBackToAccountIDWhenNoTokenFederationDefaultOIDCAudienceswhich asserts
TokenAudiencestays empty.How is this tested?
Unit tests updated and passing. The new
TestApplyHostMetadata_DoesNotFallBackToAccountIDWhenNoTokenFederationDefaultOIDCAudiencesverifies that
TokenAudienceremains empty when the field is absent.