[Feature] Add GetResolvedHostType() getter to Config for downstream host type access#1615
Open
[Feature] Add GetResolvedHostType() getter to Config for downstream host type access#1615
Conversation
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
GetResolvedHostType()public getter onConfigthat exposes the host type resolved from the/.well-known/databricks-configdiscovery endpoint, without falling back to URL pattern matching heuristics.Why
The existing
HostType()method combines two behaviors: it checks the resolved host metadata first, then falls back to URL pattern matching. Downstream consumers like the Terraform provider need access to only the metadata-resolved host type to make decisions about host-agnostic behavior — without the URL-based fallback polluting the result.Today,
resolvedHostTypeis a private field with no public accessor, so downstream packages cannot distinguish between "metadata says this is a workspace host" and "we guessed from the URL pattern."This getter provides a clean, minimal API for that use case.
What changed
Interface changes
(*Config).GetResolvedHostType() HostType— Returns the host type resolved from host metadata discovery. ReturnsHostTypeUnknownifmetadata has not been resolved or did not include a host type. Unlike
HostType(), this method does not fall back to URL pattern matching.Behavioral changes
None. This is a new accessor for an existing internal field.
Internal changes
None.
How is this tested?
4 unit tests added in
config/config_test.go:TestGetResolvedHostType_ReturnsUnknownByDefault— freshConfigreturnsHostTypeUnknownTestGetResolvedHostType_ReturnsResolvedValue— returnsWorkspaceHostwhen setTestGetResolvedHostType_AccountHost— returnsAccountHostwhen setTestGetResolvedHostType_UnifiedHost— returnsUnifiedHostwhen setAll pass locally via
go test -run TestGetResolvedHostType ./config/.