Adding statement interface tests to the comparator#1231
Closed
sreekanth-db wants to merge 2 commits intodatabricks:jdbc-comparator-updatedfrom
Closed
Adding statement interface tests to the comparator#1231sreekanth-db wants to merge 2 commits intodatabricks:jdbc-comparator-updatedfrom
sreekanth-db wants to merge 2 commits intodatabricks:jdbc-comparator-updatedfrom
Conversation
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
|
This PR has been marked as Stale because it has been open for 30 days with no activity. If you would like the PR to remain open, please remove the stale label or comment on the PR. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Statement interface comparison tests to the JDBC comparator.
Changes:
StatementTestParams.javaand wired it into the comparator. Tests ~27 Statement methods includinggetMaxRows,getQueryTimeout,getResultSetType,enquoteLiteral,enquoteIdentifier,isSimpleIdentifier, and all setter/getter config methods. Adds 68 new parameterized test invocations across both driver pairs.Testing
NO_CHANGELOG=true