Fix IndexOutOfBoundsException in Arrow Metadata Access for DDL Statements #1186
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed
IndexOutOfBoundsExceptionthat occurs when executing DDL statements (e.g.,CREATE DATABASE) using the Thrift protocol. The bug manifests when there's a mismatch between the number of Thrift column descriptors and Arrow schema fields.Root Cause
When executing DDL statements, the Databricks server behavior is:
arrowMetadata[0]without checking if the list was emptyThis mismatch caused
IndexOutOfBoundsExceptionwhen the driver tried to access arrow metadata at index 0 of an empty list.Debug Evidence
TColumnDesc (Thrift):
Arrow Schema:
Changes Made
Added bounds checking in two locations where arrow metadata is accessed:
ArrowUtil.java:247- Used byStreamingInlineArrowResultDatabricksResultSetMetaData.java:195- Used for result set metadata constructionBefore:
After:
Testing
Manual Testing
Test Case: Execute CREATE DATABASE statement
Before Fix:
IndexOutOfBoundsException: Index 0 out of bounds for length 0After Fix: Executes successfully, returns
hasResultSet=falseAdditional Notes to the Reviewer
NO_CHANGELOG=true