Skip to content

sync: add --max-concurrent-requests flag#5197

Open
igrekun wants to merge 1 commit intomainfrom
sync-max-concurrent-requests
Open

sync: add --max-concurrent-requests flag#5197
igrekun wants to merge 1 commit intomainfrom
sync-max-concurrent-requests

Conversation

@igrekun
Copy link
Copy Markdown
Contributor

@igrekun igrekun commented May 6, 2026

Changes

Expose the previously-hardcoded request concurrency cap as a flag on the databricks sync command. Defaults to the existing limit (20) so behavior is unchanged when the flag is omitted; values < 1 are rejected.

Why

When uploading multiple files ~5mb size high concurrency can trigger stream timeouts

Tests

Expose the previously-hardcoded request concurrency cap as a flag on the
`databricks sync` command. Defaults to the existing limit (20) so behavior
is unchanged when the flag is omitted; values < 1 are rejected.

Co-authored-by: Isaac
@igrekun igrekun requested a review from pietern May 6, 2026 17:37
@igrekun igrekun temporarily deployed to test-trigger-is May 6, 2026 17:38 — with GitHub Actions Inactive
@igrekun igrekun temporarily deployed to test-trigger-is May 6, 2026 17:38 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Approval status: pending

/cmd/sync/ - needs approval

Files: cmd/sync/sync.go, cmd/sync/sync_test.go
Suggested: @simonfaltum
Also eligible: @renaudhartert-db, @hectorcast-db, @parthban-db, @tanmay-db, @Divyansh-db, @tejaskochar-db, @mihaimitrea-db, @chrisst, @rauchy

/libs/sync/ - needs approval

Files: libs/sync/sync.go, libs/sync/watchdog.go
Suggested: @simonfaltum
Also eligible: @renaudhartert-db, @hectorcast-db, @parthban-db, @tanmay-db, @Divyansh-db, @tejaskochar-db, @mihaimitrea-db, @chrisst, @rauchy

General files (require maintainer)

Files: acceptance/cmd/sync-without-args/output.txt
Based on git history:

  • @pietern -- recent work in libs/sync/, cmd/sync/, acceptance/cmd/sync-without-args/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant