direct: ignore UC-managed schema property defaults#5195
Open
janniklasrose wants to merge 3 commits intomainfrom
Open
direct: ignore UC-managed schema property defaults#5195janniklasrose wants to merge 3 commits intomainfrom
janniklasrose wants to merge 3 commits intomainfrom
Conversation
UC auto-populates system-managed property keys (e.g. `unity.catalog.managed.delta.defaults.delta.enableRowTracking`) on schema creation. Without a backend_defaults rule, the planner sees the remote map as drift, emits Update, and DoUpdate sends an empty payload which UC rejects with "UpdateSchema Nothing to update". The rule only applies when both saved and new are nil, so user-set properties still drive real drift detection. Also mirror the UC behavior in the fake testserver so the no-drift invariant is exercised locally; added acceptance/.../schemas/drift/ managed_properties covering the reproducer. Co-authored-by: Isaac
Approval status: pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UC auto-populates system-managed property keys on schema creation (e.g.
unity.catalog.managed.delta.defaults.delta.enableRowTracking). Without abackend_defaultsrule, the planner sees the remote map as drift, emits an Update, and DoUpdate sends an empty payload that UC rejects withUpdateSchema Nothing to update.backend_defaultsrules covering the two known managed keys (...delta.enableRowTracking,...iceberg...feature.catalogManaged) so user-set properties still drive real drift detection.structdiffwhere a remote-only map change is emitted at the parent path: only skip the parent if every remote entry matches a configured child rule. Synthesize child paths withstructpath.NewBracketStringto match whatstructdiffproduces (rather thanNewStringKey, which would diverge for identifier-like keys).acceptance/.../schemas/drift/managed_propertiesthat proves plan/redeploy is a no-op despite the auto-populated keys.Test plan
go test ./bundle/direct/... ./libs/testserver/...go test ./acceptance -run 'TestAccept/bundle/resources/schemas'./task lint-qand./task checksNewStringKeyand passes onNewBracketString(verified by toggling)This pull request and its description were written by Isaac.