[4/5] Aitools: list command, flat structure, --skills/--agents/--include-experimental flags#4813
Open
simonfaltum wants to merge 3 commits intosimonfaltum/aitools-pr3-lifecyclefrom
Open
Conversation
9 tasks
8d6f603 to
14680ad
Compare
f2fba9a to
1243dc4
Compare
Add --skills, --agents, and --include-experimental flags to install command. Add --skills flag to update, uninstall, and version commands. Create new list command with detailed table output showing available/installed skills. Make skills subcommand hidden for backward compat while promoting flat command structure. Add selective uninstall support via UninstallOptions. Co-authored-by: Isaac
…ning - Always call SetArgs in skills install backward-compat alias (fixes Execute path inheriting parent args) - Add cobra.MaximumNArgs(1) to reject extra positional args - Remove dead installer.ListSkills function (replaced by list command) - Restore yellow color for "No agents detected" warning in install.go - Add Execute-path tests for skills install alias Co-authored-by: Isaac
Co-authored-by: Isaac
14680ad to
2dd4a43
Compare
1243dc4 to
ccf24e9
Compare
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: high Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @databricks/eng-apps-devex, @lennartkats-db Suggestions based on git history of 12 changed files (5 scored). See CODEOWNERS for path-specific ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack
Manifest v2 PR: databricks/databricks-agent-skills#35
Base:
simonfaltum/aitools-pr3-lifecycle(PR 3)Why
Commands are nested under
skillswhich burns namespace for future component types (hooks, etc.). There's no way to install specific skills, target specific agents from the CLI, or see installed status in the list output.Changes
New
listcommand: Table output with skill names, versions, installed status,[experimental]tags. Sorted alphabetically. Usestabwriterfor alignment.Flat command structure:
aitools install/update/uninstall/list/versionat the top level. Hiddenskills installandskills listaliases for backward compat.Flags:
--skills(string, comma-separated) on install, update, uninstall: operate on specific skills--skills(bool) on list, version: show detailed skills view--agents(string, comma-separated) on install: target specific agents, validates against registry, skips interactive prompt--include-experimentalon install: include experimental skillsSelective uninstall:
--skillson uninstall removes only named skills, preserves state file with remaining.Test plan
install --skills,--agents,--include-experimentalflags work--agentsvalidates against registry, errors on unknownuninstall --skillsselective removal, state preservedupdate --skillsselective updatelistshows detailed tableskills installandskills listhidden aliases work (Execute path tested)cmd/apps/init.gointegration preserved