Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions cmd/account/groups/groups.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions cmd/account/service-principals/service-principals.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions cmd/account/users/users.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions cmd/workspace/groups/groups.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions cmd/workspace/repos/overrides.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ func updateOverride(updateCmd *cobra.Command, updateReq *workspace.UpdateRepoReq
func repoArgumentToRepoID(ctx context.Context, w *databricks.WorkspaceClient, args []string) (int64, error) {
// ---- Begin copy from cmd/workspace/repos/repos.go ----
if len(args) == 0 {
promptSpinner := cmdio.Spinner(ctx)
promptSpinner <- "No REPO_ID argument specified. Loading names for Repos drop-down."
sp := cmdio.NewSpinner(ctx)
sp.Update("No REPO_ID argument specified. Loading names for Repos drop-down.")
names, err := w.Repos.RepoInfoPathToIdMap(ctx, workspace.ListReposRequest{})
close(promptSpinner)
sp.Close()
if err != nil {
return 0, fmt.Errorf("failed to load names for Repos drop-down. Please manually specify required arguments. Original error: %w", err)
}
Expand Down
24 changes: 12 additions & 12 deletions cmd/workspace/service-principals/service-principals.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions cmd/workspace/users/users.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions libs/cmdio/io.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,6 @@ func RunSelect(ctx context.Context, prompt *promptui.Select) (int, string, error
return prompt.Run()
}

func Spinner(ctx context.Context) chan string {
c := fromContext(ctx)
return c.Spinner(ctx)
}

// NewSpinner creates a new spinner for displaying progress indicators.
// The returned spinner should be closed when done to release resources.
//
Expand Down
28 changes: 0 additions & 28 deletions libs/cmdio/spinner.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,31 +165,3 @@ func (c *cmdIO) NewSpinner(ctx context.Context) *spinner {

return sp
}

// Spinner returns a channel for updating spinner status messages.
// Send messages to update the suffix, close the channel to stop.
// The spinner runs until the channel is closed or context is cancelled.
func (c *cmdIO) Spinner(ctx context.Context) chan string {
updates := make(chan string)
sp := c.NewSpinner(ctx)

// Bridge goroutine: channel -> spinner.Update()
go func() {
defer sp.Close()

for {
select {
case <-ctx.Done():
return
case msg, ok := <-updates:
if !ok {
// Channel closed
return
}
sp.Update(msg)
}
}
}()

return updates
}
Loading
Loading