feat(lib-vuetify): system theme option and theme-switcher improvements#34
Draft
BatLeDev wants to merge 3 commits into
Draft
feat(lib-vuetify): system theme option and theme-switcher improvements#34BatLeDev wants to merge 3 commits into
BatLeDev wants to merge 3 commits into
Conversation
Theme switcher options (default, dark, high contrast, dark and high contrast) now start with a capital letter in both locales.
Previously the OS theme preference (prefers-color-scheme, forced-colors) was only consulted once on the very first visit; after that the resolved value was locked in the `theme` cookie and never re-evaluated. On mobile devices that toggle light/dark over the day, the chosen theme could not follow the OS. - Add `'system'` to the `Theme` union and store it explicitly in the cookie. - New `resolveTheme()` helper derives the effective theme via `getDefaultTheme` when the user is on 'system' (or when the cookie is absent, which is now treated as an implicit 'system' choice). - Listen to `prefers-color-scheme` and `forced-colors` matchMedia changes and re-apply the theme reactively while the user is on 'system' — no reload. - Expose a 'system' radio option in the theme-switcher (i18n: Système / System). simple-directory does not read the theme cookie server-side (verified across its api/ and ui/ sources) and reuses lib-vuetify's theme-switcher directly, so the new cookie value is transparently handled there too.
…er host-provided theme offers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(lib-vue, lib-vuetify):'system'theme option — the OS theme preference (prefers-color-scheme,forced-colors) was previously consulted only on the very first visit, then locked into thethemecookie and never re-evaluated. Mobile devices that toggle light/dark over the day were stuck on the initial choice.'system'is now an explicit value of theThemeunion, resolved to the actual applied theme via a newresolveTheme()helper. AmatchMedialistener re-applies the theme reactively (no reload) while the user is on'system'. Thetheme-switcherexposes a new "Système" / "System" radio option. Verified thatsimple-directorydoes not read the theme cookie server-side and reuseslib-vuetify's theme-switcher directly, so this new cookie value is transparently handled there too.feat(lib-vue, lib-vuetify): exposeresolveThemeand let hosts provide their own theme offers —resolveTheme,AppliedTheme,Theme,FullSiteInfoand a newThemeOffersloose shape are now exported from@data-fair/lib-vue/session.js. Thetheme-switcheraccepts an optionalthemeprop so hosts whose configuration does not live insession.fullSite(e.g. the public Nuxt portal, where the theme is read fromportalConfig) can drive which radios are shown without having to fork the component. Falls back tosession.fullSite.value?.theme— historical behaviour preserved for existing data-fair UIs.fix(lib-vuetify): capitalizetheme-switcheri18n labels — the fourtheme-switcheroptions (Default/Par défaut,Dark/Sombre,High contrast/Contraste élevé,Dark and high contrast/Sombre et contraste élevé) now start with a capital letter in both locales.