docs: clarify input arrays in device placement#919
Merged
kgryte merged 6 commits intodata-apis:mainfrom Jun 23, 2025
Merged
Conversation
Member
|
This change seems reasonable to me, it's more of a clarification than anything else. This numbered list was written with creation functions in mind I believe. The Before merging this, let's ensure the discussions in data-apis/array-api-compat#293 (and perhaps other places) have been settled to ensure it's all consistent. |
Contributor
Author
lucyleeow
reviewed
Apr 23, 2025
Co-authored-by: Lucy Liu <jliu176@gmail.com>
Contributor
|
Based on linked discussions and workgroup discussion, the proposed rule changes have agreement. As such, I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify how input arrays should be considered for device placement.
This new line is a repetition of bullet point 2, three lines above:
However, I am observing very high levels of ambiguity among the community on the interpretation of this paragraph, where I've had multiple people insist that the device set in the context manager or global default device should trump the device of input arrays. At which point, since all real-life backends always have a global default device, input-to-output device propagation would fly out of the window.