Merged
Conversation
This was referenced Apr 2, 2025
iinfo/finfoiinfo/finfo
Contributor
Author
|
Suggested merge order:
|
Member
|
Not sure we want an out-of-band array-api-strict release just for this. How about adding the failing tests to the skip list for the time being. |
Contributor
Author
|
Done. pre-commit error is unrelated. |
Member
|
Thanks Guido, merged now. I'll take a look at the lintrunner error. These things are meant to be helpful, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE
This makes array-api-compat explode. Needs prerequisite PR data-apis/array-api-compat#294
CI will fail here until the next array-api-strict release, when it will pick up data-apis/array-api-strict#135