Merged
Conversation
Parrot the test from test_{argmin, argmax}
4 tasks
On torch, work around count_nonzero not implemented for uints On jax, there are problems with integers > iinfo(jnp.int32)
Member
Author
|
The test is useful for data-apis/array-api-compat#267. There are several issues with the test itself:
Explicitly limiting the range of elements runs into problems with floats: hypothesis howls about not exactly representable numbers and errors out. So an ideal fix is to cook up a strategy which both limits the range of ints and does the right thing for floats. For now, I think, I'm going to merge this test soon to unblock data-apis/array-api-compat#267 (which probably warrants a quick bugfix release of The flakiness shows up locally with |
This was referenced Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parrot the test from test_{argmin, argmax}