Closed
Conversation
crusaderky
force-pushed
the
apply_more
branch
2 times, most recently
from
c77c4f1 to
99a70fc
Compare
crusaderky
force-pushed
the
apply_more
branch
2 times, most recently
from
fa81046 to
c24f7d9
Compare
crusaderky
force-pushed
the
apply_more
branch
from
fc87dfd to
429721d
Compare
crusaderky
changed the title
crusaderky
force-pushed
the
apply_more
branch
12 times, most recently
from
d2eca86 to
69e5432
Compare
rgommers
reviewed
Jan 29, 2025
Member
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
This looks pretty good to me. The code is pretty complex, but probably about as complex as necessary. And the docs are excellent, which helps a lot.
Not approving yet because this PR is WIP and coupled to other PRs, but I'm happy with this I think - no major comments.
crusaderky
force-pushed
the
apply_more
branch
from
69e5432 to
ccffddf
Compare
Contributor
Author
|
Shelved indefinitely as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New functions
lazy_raise,lazy_warn,lazy_wait_onlazy_apply#86