MAINT: depend on array-api-compat#47
Conversation
Why? I was under the impression that "unpinned" git submodules are not bumped unless someone deliberately does so. All of SciPy's git submodules are unpinned. |
f052362 to
9fe035d
Compare
I wasn't aware of that, good to know |
7be17b2 to
82a3b6d
Compare
|
I think we will want to document somewhere what we are relying on from array-api-compat, or otherwise indicate which versions of array-api-compat this can depend on or be co-vendored with. I think I'm fine with something along the lines of "we aim for compatibility with the latest released version of array-api-compat, and your mileage may vary with older or dev versions". |
494064b to
b06cbcc
Compare
|
@lucascolley this is ready for review. Could you please enable workflows for this PR? |
|
I executed |
Unfortunately, I believe manual approval has to be given every time, for first-time contributors. Feel free to submit a separate PR with a trivial change if you want to unblock that. |
|
looks like you may want to bump the version of |
|
f0823e2 to
3a659d7
Compare
|
I've rebased this PR on top of #48 to get a more readable pixi.lock diff |
3a659d7 to
7dbe0df
Compare
8837f2a to
e3a2641
Compare
|
@lucascolley all green; ready for final review and merge |
lucascolley
left a comment
There was a problem hiding this comment.
thanks a lot @crusaderky, this looks great!
I suppose the scope of this package expanding is a blessing and a curse :). We will need to update the 'scope' section of the docs, but I'm happy to tackle this separately.
ba8d391 to
7046ee5
Compare
|
@lucascolley all comments addressed; this should be ready for merge |
|
thanks! |

at(ENH: Test for read-only arrays array-api-compat#205)Follow-up: vendoring hook in scipy