Skip to content

WIP: add axis tuple support to torch.expand_dims #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ev-br wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: add axis tuple support to torch.expand_dims #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions array_api_compat/torch/_aliases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,9 +690,24 @@ def triu(x: Array, /, *, k: int = 0) -> Array:
return torch.triu(x, k)

# Functions that aren't in torch https://github.com/pytorch/pytorch/issues/58742
def expand_dims(x: Array, /, *, axis: int = 0) -> Array:
return torch.unsqueeze(x, axis)
def expand_dims(x: Array, /, *, axis: int | tuple[int, ...]) -> Array:
if isinstance(axis, int):
return torch.unsqueeze(x, axis)
else:
# follow https://github.com/numpy/numpy/blob/maintenance/2.4.x/numpy/lib/_shape_base_impl.py#L596-L602
y_ndim = x.ndim + len(axis)

# normalize
n_axis = tuple(ax + y_ndim if ax < 0 else ax for ax in axis)
if (len(n_axis) != len(set(n_axis)) or
_builtin_any(ax < 0 or ax >= y_ndim for ax in n_axis)
):
raise ValueError(f"{axis=} not allowed for {x.shape = }")

shape_it = iter(x.shape)
shape = [1 if ax in n_axis else next(shape_it) for ax in range(y_ndim)]

return torch.reshape(x, shape)

def astype(
x: Array,
Expand Down
Loading