BUG: torch: meshgrid defaults to indexing="xy"#322
Merged
ev-br merged 1 commit intodata-apis:mainfrom May 13, 2025
Merged
Conversation
As of version 2.6, torch defaults to indexing='ij', and is planning to transition to 'xy' at some point. When it does, we'll be able to drop our wrapper.
|
@ev-br I noticed that |
Member
Author
|
(facepalm). Will send a fix in a while unless someone beats me to it. |
mdhaber
reviewed
Jun 22, 2025
| def meshgrid(*arrays: Array, indexing: Literal['xy', 'ij'] = 'xy') -> List[Array]: | ||
| # enforce the default of 'xy' | ||
| # TODO: is the return type a list or a tuple | ||
| return list(torch.meshgrid(*arrays, indexing='xy')) |
There was a problem hiding this comment.
return list(torch.meshgrid(*arrays, indexing=indexing))
|
I would do it, but I don't know why it's not caught by tests? Are they not running for torch? Anyway, opened gh-340. |
Member
Author
|
Thanks! The test this PR added is just too dumb, and only checks that the default is "xy" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of version 2.6, torch defaults to indexing='ij', and is planning to transition to 'xy' at some point. When it does, we'll be able to drop our wrapper.
cross-ref pytorch/pytorch#50276 for torch-specific details.
One other difference from the spec is that pytorch version returns a tuple of arrays, which matches numpy but deviates from jax or cupy, cross-ref data-apis/array-api#938