Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates tests to accommodate the updated ndonnx version (0.10.1) by adding conditions to xfail scenarios to match expected behavior changes.
- Added an xfail condition when converting from torch, dask.array, or jax.numpy to ndonnx.
- Updated error messages to address dtype inference issues in the new context.
Comments suppressed due to low confidence (1)
tests/test_common.py:245
- [nitpick] The xfail reason 'unable to infer dtype' is vague; consider providing more context on why dtype inference is failing for these source libraries to support more effective debugging.
elif target_library == "ndonnx" and source_library in ("torch", "dask.array", "jax.numpy"):
Member
|
While I don't understand what this does or why this is needed, if it helps unbreak the CI, fine. Thanks Guido. |
Contributor
Author
It tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreak
my heartCI