Reenable test_all, fix _aliases.__all__#286
Merged
ev-br merged 6 commits intodata-apis:mainfrom Mar 31, 2025
Merged
Conversation
Closed
This reverts commit 5473d84.
0e339fc to
9bb1021
Compare
ev-br
commented
Mar 23, 2025
Merged
Member
Author
|
I think I might want to merge this PR sooner than later, if only to restore the state of the tests and make the CI green by default. Please speak up if you want some more time to review. |
lucascolley
approved these changes
Mar 29, 2025
Member
lucascolley
left a comment
There was a problem hiding this comment.
thanks Evgeni! Just one comment
ev-br
commented
Mar 29, 2025
Co-authored-by: Evgeni Burovski <evgeny.burovskiy@gmail.com>
Member
Author
|
Okay, let's merge this. Thanks Aaron for weighing in in #283, thanks Lucas for the review. |
Member
|
This looks good to me. Better make sure all tests are actually run on CI! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes gh-283
test_allcommon._aliases.__all__which was wrongSo the
__all__list was wrong for a while, but it was not caught be tests because:$ pytest tests/locallysys.modules. So if an implementation module is not imported, it's not checked: this was the case withcommon._aliasesuntil BUG: torch: fixresult_typewith python scalars #277 added an unrelated test.