ENH: Dask: sort and argsort#239
Merged
lucascolley merged 1 commit intodata-apis:mainfrom Jan 26, 2025
Merged
Conversation
crusaderky
force-pushed
the
dask_sort
branch
4 times, most recently
from
1816c16 to
1a7316f
Compare
Contributor
Author
crusaderky
force-pushed
the
dask_sort
branch
3 times, most recently
from
c0f8617 to
8500867
Compare
Contributor
Author
|
@ev-br @lucascolley ready for review and merge. |
Closed
lucascolley
reviewed
Jan 26, 2025
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
would you like to get feedback from a Dask expert before we merge this? Or are you confident that it is at least good enough for now?
Contributor
Author
|
I'm confident that this is tolerable at least as a temporary crutch. It will work for some geometries and will go OOM for others, which IMHO is vastly better than not having anything at all. |
lucascolley
approved these changes
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crude implementation of
sortandargsortfor dask.array, which is functionally correct but can be extremely memory and network-intensive.A better solution would be to implement these two functions in dask.array itself, on top of the shuffle subsystem which is already used for
dask.dataframe.DataFrame.sort_values.FYI @fjetter @phofl @hendrikmakait