Merged
Conversation
crusaderky
commented
Jan 16, 2025
| *, | ||
| copy: bool = True, | ||
| device: Device | None = None | ||
| device: Optional[Device] = None |
Contributor
Author
There was a problem hiding this comment.
this change only matters if someone runs mypy/pyright in python 3.9. Runtime is unaffected due to from __future__ import annotations.
crusaderky
commented
Jan 16, 2025
| return xp.arange(*args, dtype=dtype, **kwargs) | ||
|
|
||
| arange = get_xp(da)(_dask_arange) | ||
| eye = get_xp(da)(_aliases.eye) |
crusaderky
commented
Jan 16, 2025
| from __future__ import annotations | ||
|
|
||
| from ...common import _aliases | ||
| from ...common._helpers import _check_device |
Contributor
Author
There was a problem hiding this comment.
Does nothing for dask
crusaderky
changed the title
Contributor
Author
|
@ev-br this is ready for review and merge |
ev-br
reviewed
Jan 16, 2025
ev-br
approved these changes
Jan 16, 2025
Member
ev-br
left a comment
ev-br
left a comment
There was a problem hiding this comment.
Looks like a nice cleanup, thanks @crusaderky
Member
|
There's a conflict now, could you resolve it please Guido |
auto-merge was automatically disabled
January 17, 2025 14:31
Head branch was pushed to by a user without write access
crusaderky
force-pushed
the
dask_cosmetic
branch
from
be4addb to
0e4d6d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.