Skip to content

fix: use RFC 5737 TEST-NET-1 IP for timeout testing #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdustinface merged 1 commit into from
Jan 1, 2026
Merged

fix: use RFC 5737 TEST-NET-1 IP for timeout testing #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions dash-spv/tests/handshake_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,15 @@ async fn test_handshake_with_mainnet_peer() {

#[tokio::test]
async fn test_handshake_timeout() {
// Test connecting to a non-routable IP to verify timeout behavior
// Using a non-routable IP that will cause the connection to hang
let peer_addr: SocketAddr = "10.255.255.1:9999".parse().expect("Valid peer address");
// Test connection timeout behavior using TEST-NET-1 from RFC 5737.
// https://datatracker.ietf.org/doc/html/rfc5737
// This IP range is reserved for documentation and will never respond.
let peer_addr: SocketAddr = "192.0.2.1:9999".parse().expect("Valid peer address");
let start = std::time::Instant::now();
let result = Peer::connect(peer_addr, 2, Network::Dash).await;
let elapsed = start.elapsed();

assert!(result.is_err(), "Connection should fail for non-routable peer");
assert!(result.is_err(), "Connection should fail for unreachable peer");
assert!(
elapsed >= Duration::from_secs(1),
"Should respect timeout duration (elapsed: {:?})",
Expand Down