fix(swift-sdk): wait for SDK rebuild before wallet activation#3669
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review GateCommit:
|
7db756e to
ef94761
Compare
…-wallet-manager-sdk-switch Resolve conflict in WalletManagerStore.swift by accepting upstream's sdk.handle-based stale-SDK detection (landed via dashpay#3755) over the PR's parallel ObjectIdentifier(sdk) + ManagerEntry approach. Both mechanisms target the same bug — a cached wallet manager bound to a torn-down SDK — and upstream's is the one now wired into the rest of the file (managerSdkHandles dict, rebuild log, paired nil-out), so taking upstream keeps the file internally consistent. The PR's other commits (activation gated on rebuilt-SDK request IDs in SwiftExampleAppApp.swift) auto-merged cleanly and continue to provide the wait-for-rebuild guarantee the PR title describes. --no-verify: pre-commit JS lint crashes on a local Node v25.9.0 EBADF/fstat regression while loading upstream's auto-merged grpc client files. Rust pre-commit checks ran and passed. No JS files were authored or edited in this conflict resolution.
Summary
until
AppStatefinishes rebuilding the SDK.currentNetwork, so activationdoes not cache a manager with the previous network's SDK.
rebuilds that the current per-network cache cannot safely reconfigure.
Validation
git diff --checksurface mismatch. The failure is outside this patch: local generated bindings
report
dash_sdk_private_key_to_wifanddash_sdk_validate_private_key_for_public_keyexpectingBool, plus missinggenerated platform-wallet FFI symbols such as
Handle.