-
Notifications
You must be signed in to change notification settings - Fork 7
feat(dashmint-lab): show mint supply, collapse form when sold out #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thephez
wants to merge
9
commits into
main
Choose a base branch
from
dashmint/tokens-pt2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e53a144
refactor(dashnote-starter): rework sign-in page for clearer onboarding
thephez fb25599
feat(dashmint-lab): show supply on mint page and collapse form when s…
thephez b9a298f
test(dashmint-lab): cover supply display, sold-out collapse, and star…
thephez e45f9c6
style(dashmint): starter pack button adjust
thephez 46ef0aa
test(dashmint-lab): fix e2e price parsing and mobile drawer dismiss
thephez 45425a2
fix(dashmint-lab): keep mint page counts fresh across tab switches
thephez bb6f4eb
docs(dashmint-lab): clarify starter pack copy with card count up front
thephez 6be5772
chore(types): add tokens.totalSupply to ConnectedDashClientLike
thephez 6306ba6
chore(dashmint-lab): update default contract id
thephez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block mint actions while supply is still unknown.
On a cold load,
mintedCountstarts asnull, and it staysnullon the first fetch failure. In that state both actions are still enabled, so users can submit before the sold-out check has resolved. That defeats the new sold-out gating this PR is adding.Suggested fix
Also applies to: 76-78, 100-105, 240-245, 278-283
🤖 Prompt for AI Agents