Skip to content

Conversation

@ktechmidas
Copy link
Contributor

@ktechmidas ktechmidas commented Dec 30, 2025

Issue being fixed or feature implemented

Removed spork 24 as not needed in recent versions of Dash Core

What was done?

Removed spork 24 as not needed in recent versions of Dash Core

How Has This Been Tested?

Deployed devnet

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

Release Notes

  • Infrastructure Updates
    • Refined feature activation workflow to improve control flow and error handling during network spork management operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

📝 Walkthrough

Walkthrough

SPORK_24_TEST_EHF was removed from the batch activation list in the Ansible sporks task file. The dedicated EHF activation task remains unchanged with the same conditional logic, now handling this spork separately from batch operations.

Changes

Cohort / File(s) Change Summary
Spork Activation Refactoring
ansible/roles/activate_dashd_sporks/tasks/main.yml
Removed SPORK_24_TEST_EHF from batch spork activation loop; will be processed by dedicated EHF activation task instead. Control flow split into two distinct paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A spork once bundled, now set apart,
EHF takes its own special cart,
Two paths emerge from one, you see,
Activation flows more gracefully!
hippity-hop

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: Remove spork' is vague and lacks specificity about which spork is being removed or why. Revise the title to be more specific, such as 'chore: Remove SPORK_24_TEST_EHF from batch activation' to clearly identify the change and its scope.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4eb2541 and 506141f.

📒 Files selected for processing (1)
  • ansible/roles/activate_dashd_sporks/tasks/main.yml
💤 Files with no reviewable changes (1)
  • ansible/roles/activate_dashd_sporks/tasks/main.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@vivekgsharma vivekgsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktechmidas ktechmidas merged commit 5bb6cb8 into v1.0-dev Dec 31, 2025
2 checks passed
@ktechmidas ktechmidas deleted the chore/remove-ehf-spork branch December 31, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants