Skip to content

If we cannot build with requested AI feature we should fail, not disable it#20804

Merged
TurboGit merged 1 commit intodarktable-org:masterfrom
victoryforce:fail-not-disable-AI-if-cannot-build
Apr 13, 2026
Merged

If we cannot build with requested AI feature we should fail, not disable it#20804
TurboGit merged 1 commit intodarktable-org:masterfrom
victoryforce:fail-not-disable-AI-if-cannot-build

Conversation

@victoryforce
Copy link
Copy Markdown
Collaborator

The continuation of #20695. Better to fail then to produce a crippled build.

@andriiryzhkov
Copy link
Copy Markdown
Contributor

That is when USE_AI=ON and dependencies are not met - fail with error? I agree, that's a better approach.

Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok by me too. Thanks!

@TurboGit TurboGit added this to the 5.6 milestone Apr 13, 2026
@TurboGit TurboGit added priority: low core features work as expected, only secondary/optional features don't feature: redesign current features to rewrite labels Apr 13, 2026
@TurboGit TurboGit merged commit 4baa6a0 into darktable-org:master Apr 13, 2026
13 of 15 checks passed
@victoryforce victoryforce deleted the fail-not-disable-AI-if-cannot-build branch April 13, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: redesign current features to rewrite priority: low core features work as expected, only secondary/optional features don't

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants