Skip to content

po/fix auto presets - code refactoring.#20058

Merged
TurboGit merged 2 commits intomasterfrom
po/fix-auto-presets
Jan 3, 2026
Merged

po/fix auto presets - code refactoring.#20058
TurboGit merged 2 commits intomasterfrom
po/fix-auto-presets

Conversation

@TurboGit
Copy link
Copy Markdown
Member

@TurboGit TurboGit commented Jan 2, 2026

Use new dt_presets_get_filter routine. Ensure that the RAW/LDR is
a proper AND with the other filter items (HDR, Color, Monochrome).

Closes #20047.

@TurboGit TurboGit added this to the 5.4.1 milestone Jan 2, 2026
@TurboGit TurboGit added bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters scope: image processing correcting pixels scope: DAM managing files, collections, archiving, metadata, etc. release notes: pending labels Jan 2, 2026
@TurboGit TurboGit marked this pull request as draft January 2, 2026 15:01
@TurboGit TurboGit force-pushed the po/fix-auto-presets branch from 881f732 to e8fa7bd Compare January 2, 2026 15:02
@TurboGit TurboGit marked this pull request as ready for review January 2, 2026 16:04
@jenshannoschwalm
Copy link
Copy Markdown
Collaborator

  1. works for me
  2. no idea why the windows build hangs so often

Avoid discrepancies because of duplicated code.

Part of #20047
Use new dt_presets_get_filter routine. Ensure that the RAW/LDR is
a proper AND with the other filter items (HDR, Color, Monochrome).

Closes #20047.
@TurboGit TurboGit force-pushed the po/fix-auto-presets branch from e8fa7bd to 83980b2 Compare January 2, 2026 16:56
@TurboGit TurboGit merged commit 6e40c0d into master Jan 3, 2026
6 checks passed
@TurboGit TurboGit deleted the po/fix-auto-presets branch January 3, 2026 16:14
@TurboGit
Copy link
Copy Markdown
Member Author

TurboGit commented Jan 3, 2026

@jenshannoschwalm : Thanks for the review.

For 2, don't know... I've followed a bit the discussion and it seems to me that is is possible due to some driver (USB? something else...?). Kind of strange... Also the issue could be related to the splash screen as it seems to be causing troubles for some users. On my side I have tried dt without splash screen and did not have reproduce the lock.

My current thinking is that this could be more generic than just Windows even if it reproduce lot more on Windows.

@jenshannoschwalm
Copy link
Copy Markdown
Collaborator

jenshannoschwalm commented Jan 3, 2026

@TurboGit there seems to be something badly wrong with this.

Former auto applied preset are changed, not applied any longer.

files with .dng (small letters) don't get auto-presets applied any longer ???

color calibration should be auto enabled for scene referred workflows.

Or did i mess up my database on some other thing

@TurboGit
Copy link
Copy Markdown
Member Author

TurboGit commented Jan 4, 2026

Ref #20065

@gi-man
Copy link
Copy Markdown
Contributor

gi-man commented Jan 4, 2026

Former auto applied preset are changed, not applied any longer.

Most of my auto-preset are not being applied. Color calibration does get applied. Tested with cr3, cr2 and ORF.

@jenshannoschwalm
Copy link
Copy Markdown
Collaborator

Hmm, this is somewhat fishy. Last compile everything seemed to work, now my auto appled presets are working but agx does not (default workflow), sigmoid works

@TurboGit
Copy link
Copy Markdown
Member Author

TurboGit commented Jan 4, 2026

@jenshannoschwalm @gi-man : See #20076. The preset was using FOR_HDR and this is wrong as it won't apply to non HDR pictures. All this was broken before, so this was unnoticed until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters scope: DAM managing files, collections, archiving, metadata, etc. scope: image processing correcting pixels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-apply Preset applying to JXL despite de-selecting non-raw

3 participants