Skip to content

Conversation

@TurboGit
Copy link
Member

@TurboGit TurboGit commented Jan 1, 2026

  1. Make the dialog a bit larger
  2. Rework color to ensure the selection is seen

Closes #19896
Closes #20051

@TurboGit
Copy link
Member Author

TurboGit commented Jan 1, 2026

@zisoft : If you have an X11 box (I'm currently only with Wayland), can you check this? TIA.

@TurboGit TurboGit added this to the 5.4.1 milestone Jan 1, 2026
@TurboGit TurboGit added bugfix pull request fixing a bug scope: UI user interface and interactions labels Jan 1, 2026
@zisoft
Copy link
Collaborator

zisoft commented Jan 1, 2026

No X11, I am on a Mac.

Unfortunately not fixed, still no highlight when using the arrow keys:

Bildschirmfoto 2026-01-01 um 21 20 22

Highlight on mouse hover works fine.

@zisoft
Copy link
Collaborator

zisoft commented Jan 1, 2026

very strange, when I set

#tag-completion *:selected
{
  background-color: green;
}

it works:

Bildschirmfoto 2026-01-01 um 21 29 15

@zisoft
Copy link
Collaborator

zisoft commented Jan 1, 2026

@TurboGit:

the color should be @selected_bg_color

Bildschirmfoto 2026-01-01 um 21 32 19

@TurboGit
Copy link
Member Author

TurboGit commented Jan 2, 2026

@zisoft : You're using which theme?

1. Make the dialog a bit larger
2. Rework color to ensure the selection is seen

Closes #19896
Closes #20051
@TurboGit
Copy link
Member Author

TurboGit commented Jan 2, 2026

Tested with @selected_bg_color on darker, dark and grey theme. All ok on my side on Wayland.

@zisoft
Copy link
Collaborator

zisoft commented Jan 2, 2026

@TurboGit : I use darktable-elegant-grey

@TurboGit
Copy link
Member Author

TurboGit commented Jan 2, 2026

@TurboGit : I use darktable-elegant-grey

Strange that is was ok on my side as I'm using the same theme.

@TurboGit TurboGit merged commit 1bbdd50 into master Jan 2, 2026
6 checks passed
@TurboGit TurboGit deleted the po/fix-tag-entry branch January 2, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keyboard-based tagging in lighttable: GUI issue in selection list Input field for entering tags (Ctrl-T) is way too small

3 participants